fix(snowflake): invalid token does not prevent to retrieve a new one #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
even if previous token has any problem
raphaelvignes
approved these changes
Oct 18, 2021
| access_token = jwt.decode( | ||
| self.access_token, | ||
| options={ | ||
| 'verify_signature': False, # this should be enough according to docs, but doesn't seem like it is |
There was a problem hiding this comment.
I guess this has changed :/
davinov
force-pushed
the
fix-snowflake-token-validity
branch
from
0b866c2
to
3650f79
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #497, some claims in the token are validated (even if there is
'verify_signature': False), which could prevent new token to be fetched. There was then no way to connect, once the validity has been broken once.