Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: when testing connection, set timeout to 10s when checking if port is opened [TCTC-7385] #1772

Merged
merged 2 commits into from
Sep 13, 2024
Merged

feat: when testing connection, set timeout to 10s when checking if port is opened [TCTC-7385] #1772

merged 2 commits into from
Sep 13, 2024

Conversation

fspot
Copy link
Member

@fspot fspot commented Sep 13, 2024

@fspot fspot added the bug Something isn't working label Sep 13, 2024
@fspot fspot self-assigned this Sep 13, 2024
@fspot fspot force-pushed the set-timeout-check-port-opened branch from 7c97509 to 5a88d69 Compare September 13, 2024 10:14
@fspot fspot force-pushed the set-timeout-check-port-opened branch from 5a88d69 to 746ce69 Compare September 13, 2024 10:15
julien-pinchelimouroux
julien-pinchelimouroux approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@julien-pinchelimouroux julien-pinchelimouroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@fspot fspot merged commit a55c839 into master Sep 13, 2024
4 checks passed
@fspot fspot deleted the set-timeout-check-port-opened branch September 13, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-pinchelimouroux julien-pinchelimouroux julien-pinchelimouroux approved these changes

Assignees

@fspot fspot

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fspot @julien-pinchelimouroux