Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecate missing property in ShortUser #77

Merged
merged 4 commits into from
Apr 11, 2023
Merged

fix: deprecate missing property in ShortUser #77

merged 4 commits into from
Apr 11, 2023

Conversation

null8626
Copy link
Member

@null8626 null8626 commented Apr 6, 2023

The discriminator property doesn't exist in the objects returned in /bots/votes. (see https://docs.top.gg/api/bot/#example-response-1)

The `discriminator` property doesn't exist in the objects returned in `/bots/:bot_id/votes`. (see https://docs.top.gg/api/bot/#last-1000-votes)
@netlify
Copy link

netlify bot commented Apr 6, 2023

Deploy Preview for topgg-node-sdk-docs ready!

Name Link
🔨 Latest commit 5ac921e
🔍 Latest deploy log https://app.netlify.com/sites/topgg-node-sdk-docs/deploys/64348146b70ced00085dca05
😎 Deploy Preview https://deploy-preview-77--topgg-node-sdk-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@null8626
Copy link
Member Author

null8626 commented Apr 6, 2023

Also, it seems that the function for /bots/:bot_id/votes is missing. Not sure if this is intentional or not...

@null8626 null8626 changed the title fix: remove missing property in ShortUser fix: deprecate missing property in ShortUser Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants