Skip to content

Commit

Permalink
Call base class's close method and rename internal variable
Browse files Browse the repository at this point in the history
  • Loading branch information
Toni-SM committed Aug 5, 2024
1 parent e252c06 commit d88da15
Showing 1 changed file with 5 additions and 10 deletions.
15 changes: 5 additions & 10 deletions skrl/envs/wrappers/torch/isaaclab_envs.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def __init__(self, env: Any) -> None:
super().__init__(env)

self._reset_once = True
self._obs_dict = None
self._observations = None
self._info = {}

@property
Expand Down Expand Up @@ -60,8 +60,8 @@ def step(self, actions: torch.Tensor) -> Tuple[torch.Tensor, torch.Tensor, torch
:return: Observation, reward, terminated, truncated, info
:rtype: tuple of torch.Tensor and any other info
"""
self._obs_dict, reward, terminated, truncated, self._info = self._env.step(actions)
return self._obs_dict["policy"], reward.view(-1, 1), terminated.view(-1, 1), truncated.view(-1, 1), self._info
self._observations, reward, terminated, truncated, self._info = self._env.step(actions)
return self._observations["policy"], reward.view(-1, 1), terminated.view(-1, 1), truncated.view(-1, 1), self._info

def reset(self) -> Tuple[torch.Tensor, Any]:
"""Reset the environment
Expand All @@ -70,16 +70,11 @@ def reset(self) -> Tuple[torch.Tensor, Any]:
:rtype: torch.Tensor and any other info
"""
if self._reset_once:
self._obs_dict, self._info = self._env.reset()
self._observations, self._info = self._env.reset()
self._reset_once = False
return self._obs_dict["policy"], self._info
return self._observations["policy"], self._info

def render(self, *args, **kwargs) -> None:
"""Render the environment
"""
pass

def close(self) -> None:
"""Close the environment
"""
self._env.close()

0 comments on commit d88da15

Please sign in to comment.