Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Layout Engine for Fiber Reconciler #472

Merged
merged 73 commits into from
May 30, 2022
Merged

Custom Layout Engine for Fiber Reconciler #472

merged 73 commits into from
May 30, 2022

Commits on Feb 6, 2022

  1. Initial Reconciler using visitor pattern

    @carson-katri
    carson-katri committed Feb 6, 2022
    Configuration menu
    Copy the full SHA
    84018db View commit details
    Browse the repository at this point in the history

  2. Preliminary static HTML renderer using the new reconciler

    @carson-katri
    carson-katri committed Feb 6, 2022
    Configuration menu
    Copy the full SHA
    aa8c4dd View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2022

  1. Add environment

    @carson-katri
    carson-katri committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    67b3509 View commit details
    Browse the repository at this point in the history

  2. Initial DOM renderer

    @carson-katri
    carson-katri committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    7f96bc1 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2022

  1. Nearly-working and simplified reconciler

    @carson-katri
    carson-katri committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    4ea2247 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2022

  1. Working reconciler for HTML/DOM renderers

    @carson-katri
    carson-katri committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    026f00b View commit details
    Browse the repository at this point in the history

  2. Rename files, and split code across files

    @carson-katri
    carson-katri committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    e340ed5 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2022

  1. Add some documentation and refinements

    @carson-katri
    carson-katri committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    885ba06 View commit details
    Browse the repository at this point in the history

  2. Remove GraphRendererTests

    @carson-katri
    carson-katri committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    dd8a2eb View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2022

  1. Initial layout engine (only implemented for the TestRenderer)

    @carson-katri
    carson-katri committed Feb 19, 2022
    Configuration menu
    Copy the full SHA
    88f689f View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2022

  1. Layout engine for the DOM renderer

    @carson-katri
    carson-katri committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    a9af988 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2022

  1. Refined layout pass

    @carson-katri
    carson-katri committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    26ce229 View commit details
    Browse the repository at this point in the history

  2. Revise positioning and restoration of position styles on .update

    @carson-katri
    carson-katri committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    2891e6b View commit details
    Browse the repository at this point in the history

  3. Re-add Optional.body for StackReconciler-based renderers

    @carson-katri
    carson-katri committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    055c826 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2022

  1. Merge branch 'fiber/core' of https://github.com/TokamakUI/Tokamak int… 

    …o fiber/layout
    @carson-katri
    carson-katri committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    7b98447 View commit details
    Browse the repository at this point in the history

  2. Add text measurement

    @carson-katri
    carson-katri committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    9902ace View commit details
    Browse the repository at this point in the history

  3. Add spacing to StackLayout

    @carson-katri
    carson-katri committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    d576798 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2022

  1. Add benchmarks to compare the stack/fiber reconcilers

    @carson-katri
    carson-katri committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    c457dce View commit details
    Browse the repository at this point in the history

  2. Fix some issues created for the StackReconciler, and add update bench… 

    …marks
    @carson-katri
    carson-katri committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    be6aa89 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2022

  1. Add BenchmarkState.measure to only calculate the time to update

    @carson-katri
    carson-katri committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    ac5c110 View commit details
    Browse the repository at this point in the history

  2. Fix hang in update shallow benchmark

    @carson-katri
    carson-katri committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    0d82cec View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2022

  1. Merge branch 'main' into fiber/core

    @MaxDesiatov
    MaxDesiatov committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    42c7c01 View commit details
    Browse the repository at this point in the history

  2. Fix build errors

    @MaxDesiatov
    MaxDesiatov committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    7ef9bed View commit details
    Browse the repository at this point in the history

  3. Address build issues

    @MaxDesiatov
    MaxDesiatov committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    34cd9d7 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2022

  1. Merge branch 'main' into fiber/core

    @MaxDesiatov
    MaxDesiatov committed May 12, 2022
    Configuration menu
    Copy the full SHA
    6a846f4 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2022

  1. Merge branch 'main' of https://github.com/TokamakUI/Tokamak into fibe… 

    …r/core
    @carson-katri
    carson-katri committed May 19, 2022
    Configuration menu
    Copy the full SHA
    7d705eb View commit details
    Browse the repository at this point in the history

  2. Remove File.swift headers

    @carson-katri
    carson-katri committed May 19, 2022
    Configuration menu
    Copy the full SHA
    a70a938 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2022

  1. Rename Element -> FiberElement and Element.Data -> FiberElement.Content

    @carson-katri
    carson-katri committed May 20, 2022
    Configuration menu
    Copy the full SHA
    485da76 View commit details
    Browse the repository at this point in the history

  2. Add doc comment explaining unowned usage

    @carson-katri
    carson-katri committed May 20, 2022
    Configuration menu
    Copy the full SHA
    81deb5a View commit details
    Browse the repository at this point in the history

Commits on May 21, 2022

  1. Add doc comments explaining implicitly unwrapped optionals

    @carson-katri
    carson-katri committed May 21, 2022
    Configuration menu
    Copy the full SHA
    74ee853 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2022

  1. Attempt to use Swift instead of JS for applying mutations

    @carson-katri
    carson-katri committed May 22, 2022
    Configuration menu
    Copy the full SHA
    8a8c075 View commit details
    Browse the repository at this point in the history

  2. Fix issue with not applying updates to DOMFiberElement

    @carson-katri
    carson-katri committed May 22, 2022
    Configuration menu
    Copy the full SHA
    b7cc779 View commit details
    Browse the repository at this point in the history

  3. Add comment explaining manual implementation of Hashable for Property… 

    …Info
    @carson-katri
    carson-katri committed May 22, 2022
    Configuration menu
    Copy the full SHA
    78d0bf5 View commit details
    Browse the repository at this point in the history

  4. Fix linter issues

    @carson-katri
    carson-katri committed May 22, 2022
    Configuration menu
    Copy the full SHA
    4becea3 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2022

  1. Remove dynamicMember label from subscript

    @carson-katri
    carson-katri committed May 23, 2022
    Configuration menu
    Copy the full SHA
    8c9141b View commit details
    Browse the repository at this point in the history

  2. Re-enable carton test

    @carson-katri
    carson-katri committed May 23, 2022
    Configuration menu
    Copy the full SHA
    33f0e67 View commit details
    Browse the repository at this point in the history

  3. Merge fiber/core

    @carson-katri
    carson-katri committed May 23, 2022
    Configuration menu
    Copy the full SHA
    316468c View commit details
    Browse the repository at this point in the history

  4. Attempt GTK fix

    @carson-katri
    carson-katri committed May 23, 2022
    Configuration menu
    Copy the full SHA
    4d86f89 View commit details
    Browse the repository at this point in the history

  5. Add option to disable layout in the FiberReconciler

    @carson-katri
    carson-katri committed May 23, 2022
    Configuration menu
    Copy the full SHA
    3189e77 View commit details
    Browse the repository at this point in the history

  6. Re-enable TokamakDemo with StackReconciler

    @carson-katri
    carson-katri committed May 23, 2022
    Configuration menu
    Copy the full SHA
    104f14f View commit details
    Browse the repository at this point in the history

Commits on May 24, 2022

  1. Merge fiber/core

    @carson-katri
    carson-katri committed May 24, 2022
    Configuration menu
    Copy the full SHA
    0d0a9c7 View commit details
    Browse the repository at this point in the history

  2. Merge main (take ours)

    @carson-katri
    carson-katri committed May 24, 2022
    Configuration menu
    Copy the full SHA
    836ac36 View commit details
    Browse the repository at this point in the history

  3. Restore CI config

    @carson-katri
    carson-katri committed May 24, 2022
    Configuration menu
    Copy the full SHA
    389b3e8 View commit details
    Browse the repository at this point in the history

  4. Restore CI config

    @carson-katri
    carson-katri committed May 24, 2022
    Configuration menu
    Copy the full SHA
    a20d94b View commit details
    Browse the repository at this point in the history

  5. Add file headers and cleanup structure

    @carson-katri
    carson-katri committed May 24, 2022
    Configuration menu
    Copy the full SHA
    05d5a24 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2022

  1. Merge branch 'main' of github.com:tokamakui/tokamak into fiber/layout

    @carson-katri
    carson-katri committed May 26, 2022
    Configuration menu
    Copy the full SHA
    f628cba View commit details
    Browse the repository at this point in the history

  2. Add 'px' to font-size in test outputs

    @carson-katri
    carson-katri committed May 26, 2022
    Configuration menu
    Copy the full SHA
    d507848 View commit details
    Browse the repository at this point in the history

  3. Remove extra newlines

    @carson-katri
    carson-katri committed May 26, 2022
    Configuration menu
    Copy the full SHA
    65e78e8 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2022

  1. Keep track of 'elementChildren' so children are positioned in the cor… 

    …rect order
    @carson-katri
    carson-katri committed May 27, 2022
    Configuration menu
    Copy the full SHA
    f94d733 View commit details
    Browse the repository at this point in the history

  2. Use a ViewVisitor to pass the correct View type to the proposeSize fu… 

    …nction
    @carson-katri
    carson-katri committed May 27, 2022
    Configuration menu
    Copy the full SHA
    001cd4b View commit details
    Browse the repository at this point in the history

Commits on May 28, 2022

  1. Add support for view modifiers

    @carson-katri
    carson-katri committed May 28, 2022
    Configuration menu
    Copy the full SHA
    f89d24d View commit details
    Browse the repository at this point in the history

  2. Add frame modifier to demonstrate modifiers

    @carson-katri
    carson-katri committed May 28, 2022
    Configuration menu
    Copy the full SHA
    10368b1 View commit details
    Browse the repository at this point in the history

  3. Fix TestRenderer

    @carson-katri
    carson-katri committed May 28, 2022
    Configuration menu
    Copy the full SHA
    f926fbe View commit details
    Browse the repository at this point in the history

  4. Remove unused property

    @carson-katri
    carson-katri committed May 28, 2022
    Configuration menu
    Copy the full SHA
    4d96217 View commit details
    Browse the repository at this point in the history

  5. Fix doc comment

    @carson-katri
    carson-katri committed May 28, 2022
    Configuration menu
    Copy the full SHA
    aeb5983 View commit details
    Browse the repository at this point in the history

  6. Fix linter issues and refactor slightly

    @carson-katri
    carson-katri committed May 28, 2022
    Configuration menu
    Copy the full SHA
    3265b74 View commit details
    Browse the repository at this point in the history

  7. Fix benchmark builds

    @carson-katri
    carson-katri committed May 28, 2022
    Configuration menu
    Copy the full SHA
    b6c5d8e View commit details
    Browse the repository at this point in the history

  8. Attempt to fix benchmarks

    @carson-katri
    carson-katri committed May 28, 2022
    Configuration menu
    Copy the full SHA
    8ca135c View commit details
    Browse the repository at this point in the history

  9. Fix sibling layout issues

    @carson-katri
    carson-katri committed May 28, 2022
    Configuration menu
    Copy the full SHA
    8779df6 View commit details
    Browse the repository at this point in the history

  10. Restore original demo

    @carson-katri
    carson-katri committed May 28, 2022
    Configuration menu
    Copy the full SHA
    90e1c5d View commit details
    Browse the repository at this point in the history

Commits on May 29, 2022

  1. Address review comments

    @carson-katri
    carson-katri committed May 29, 2022
    Configuration menu
    Copy the full SHA
    0cf20a0 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2022

  1. Remove maxAxis and fitAxis properties

    @carson-katri
    carson-katri committed May 30, 2022
    Configuration menu
    Copy the full SHA
    8a96570 View commit details
    Browse the repository at this point in the history

  2. Use switch instead of ternary operators

    @carson-katri
    carson-katri committed May 30, 2022
    Configuration menu
    Copy the full SHA
    ca7fb6b View commit details
    Browse the repository at this point in the history

  3. Add more documentation to layout steps

    @carson-katri
    carson-katri committed May 30, 2022
    Configuration menu
    Copy the full SHA
    e90f1a1 View commit details
    Browse the repository at this point in the history

  4. Resolve reconciler issue due to alternate child not being cleared/rel… 

    …eased
    @carson-katri
    carson-katri committed May 30, 2022
    Configuration menu
    Copy the full SHA
    a0b71d3 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Max Desiatov <max@desiatov.com>
    @carson-katri @MaxDesiatov
    carson-katri and MaxDesiatov committed May 30, 2022
    Configuration menu
    Copy the full SHA
    8cd570a View commit details
    Browse the repository at this point in the history

  6. Reuse Text resolution code.

    @carson-katri
    carson-katri committed May 30, 2022
    Configuration menu
    Copy the full SHA
    c0567d4 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'fiber/layout' of github.com:tokamakui/tokamak into fibe… 

    …r/layout
    @carson-katri
    carson-katri committed May 30, 2022
    Configuration menu
    Copy the full SHA
    7a56023 View commit details
    Browse the repository at this point in the history

  8. Add more documentation

    @carson-katri
    carson-katri committed May 30, 2022
    Configuration menu
    Copy the full SHA
    e9671c3 View commit details
    Browse the repository at this point in the history

  9. Fix typo

    @carson-katri
    carson-katri committed May 30, 2022
    Configuration menu
    Copy the full SHA
    3c92483 View commit details
    Browse the repository at this point in the history

  10. Use structs for LayoutComputers

    @carson-katri
    carson-katri committed May 30, 2022
    Configuration menu
    Copy the full SHA
    cfaf990 View commit details
    Browse the repository at this point in the history

  11. Update AlignmentID demo

    @carson-katri
    carson-katri committed May 30, 2022
    Configuration menu
    Copy the full SHA
    cff213d View commit details
    Browse the repository at this point in the history

  12. Fix weird formatting

    @carson-katri
    carson-katri committed May 30, 2022
    Configuration menu
    Copy the full SHA
    cdb5df2 View commit details
    Browse the repository at this point in the history