Add Material to the HTML renderer
#418
Conversation
…sm/Tokamak into swiftui3-styles
|
I added a snapshot test, but the filter doesn't seem to be screenshot correctly... |
| @@ -203,6 +203,31 @@ final class RenderingTests: XCTestCase { | |||
| ) | |||
| #endif | |||
| } | |||
|
|
|||
| func testMaterial() { | |||
| #if compiler(>=5.5) || os(WASI) | |||
There was a problem hiding this comment.
Just curious, what features of 5.5 are used here? Since we don't have the latest Xcode on GitHub Actions, these tests won't run there, right?
There was a problem hiding this comment.
It just needs the newest SwiftUI in Xcode 13 so it can find Material, and some new modifiers. I wasn't sure what the correct way to restrict it to that is besides using Xcode 13 on CI or restricting to the compiler version shipping with that Xcode version.
There was a problem hiding this comment.
Right, but these tests should be using Material from Tokamak, not SwiftUI. There's no import SwiftUI in RenderingTests.swift at all, and there's an explicit import of TokamakStaticHTML, so maybe removing this #if compiler(>=5.5) shouldn't be an issue? And os(WASI) shouldn't have any effect since snapshot tests aren't supported on that platform anyway, and there's a top-level platform check for macOS in that file.
There was a problem hiding this comment.
Oops, sorry. Mixed that up with the demo files which wouldn't build. I'll get rid of it.
This adds the new iOS 15+
MaterialShapeStyle. They currently only work forbackgroundmodifiers on the web usingbackdrop-filter.Tokamak:
SwiftUI:
