Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CGFloat, CGPoint, CGRect from Foundation #411

Merged
merged 3 commits into from
Jun 19, 2021
Merged

Use CGFloat, CGPoint, CGRect from Foundation #411

merged 3 commits into from
Jun 19, 2021

Conversation

MaxDesiatov
Copy link
Collaborator

Resolves #404.

This also allows us to write more tests that are source-compatible with SwiftUI.

@MaxDesiatov MaxDesiatov added the SwiftUI compatibility Tokamak API differences with SwiftUI label Jun 16, 2021
@MaxDesiatov MaxDesiatov requested a review from a team June 16, 2021 22:55
@MaxDesiatov MaxDesiatov mentioned this pull request Jun 19, 2021
Merged
foscomputerservices
foscomputerservices approved these changes Jun 19, 2021
View reviewed changes
Copy link
Contributor

@foscomputerservices foscomputerservices left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me ✅

@MaxDesiatov MaxDesiatov merged commit ae219e9 into main Jun 19, 2021
@MaxDesiatov MaxDesiatov deleted the foundation-types branch June 19, 2021 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foscomputerservices foscomputerservices foscomputerservices approved these changes

Assignees
No one assigned
Labels
SwiftUI compatibility Tokamak API differences with SwiftUI
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use NSGeometry types from Foundation
2 participants
@MaxDesiatov @foscomputerservices