Reuse reflection code from the Swift toolchain #384
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to keep this open (albeit in the draft state) until we have some benchmarking automation to compare if there are any performance or code size benefits by any chance. |
|
Could the benchmarks we have now open this back up? |
|
Yes, they could. I'm not sure when I'll have time to do set up these benchmarks though, sorry. Feel free to pick it up if you're interested. |
|
Closed by mistake while commenting, reopening now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another attempt to resolve #367.
Seems to work in all known cases so far.This reuses code that OpenCombine previously used for reflection, but didn't need after all. It's transplanted from the toolchain with namespace names changed to avoid naming collisions.