Stop assuming pointer type for generic arguments #383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't make the issue completely go away. I'm still seeing it in slightly larger apps, and I still can't reproduce it with a test renderer to add a unit test. I suspect this only shuffles some memory around and makes the set of conditions for reproduction shift. Working on a slightly different approach for this right now... |
|
Even though we've found a different way to solve the original issue, I'd like to keep this open (albeit in the draft state) until we have some benchmarking automation to compare if there are any performance or code size benefits by any chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to fully resolve #367.
You were right @foscomputerservices, this was a strict aliasing issue. 😅 This forum post made it crystal clear to me: