-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NavigationView causes Error: Detected stack-buffer-overflow #445
Comments
This is a regression; it broke in 21c21cd. |
Maybe using loops instead of recursion in the reconciler/MountedElements code would reduce our stack memory consumption? That's the first thing I'd try first, if anyone is interested in picking it up. Could also potentially help with performance even on other platforms, probably provable through our existing very basic benchmarks. |
One workaround in the meantime could be setting the stack size explicitly to something large enough in |
This looks like the same |
Great find with the workaround! Please feel free to submit a PR. Even if it fixes only a subset of cases, it's still worth merging I think. |
Describe the bug
I'm just starting exploring Tokamak and created a project using the tokamak template as described in the readme.
I added a simple
NavigationView
to the body ofContentView
as follows:Saving the file to trigger a reload shows a blank white screen. The Google Chrome console prints the following error:
in
carton dev
there seems to be no problem:Expected behavior
The
NavigationView
should not produce a stack-buffer-overflow error and the content insideNavigationView
should be visible in someway appropriate for a navigation view in a web app.Screenshots
Desktop (please complete the following information):
Additional context
From the progress.md file, I can see NavigationView is 🚧, but I couldn't know how completed it is. I am sorry for reporting the issue if it's already known.
The text was updated successfully, but these errors were encountered: