Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare types by module name, not just type name in the reconciler #218

Closed
MaxDesiatov opened this issue Jul 27, 2020 · 0 comments · Fixed by #391
Closed

Compare types by module name, not just type name in the reconciler #218

MaxDesiatov opened this issue Jul 27, 2020 · 0 comments · Fixed by #391
Labels
bug Something isn't working

Comments

@MaxDesiatov
Copy link
Collaborator

Surfacing this FIXME, which it would be great to fix before we get wider adoption. As far as I understand the module name is already contained in the mangled type name, not sure if the Runtime library gives access to it though.
@MaxDesiatov MaxDesiatov added the bug Something isn't working label Jul 27, 2020
@MaxDesiatov MaxDesiatov mentioned this issue Jan 25, 2021
Closed
@MaxDesiatov MaxDesiatov mentioned this issue Mar 17, 2021
Merged
MaxDesiatov added a commit that referenced this issue Mar 20, 2021
@MaxDesiatov
Use String(reflecting:) vs String(describing:) (#391)
bde7de9 
Resolves #218.

`String(describing:)` initializer applied to metatypes does not include a module name, which can cause problems if two different types with same name come from different modules.

OTOH `String(reflecting:)` does include module name, which makes these reflection strings slightly longer, but should prevent obscure issues with name collisions from happening.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use String(reflecting:) vs String(describing:) TokamakUI/Tokamak
1 participant
@MaxDesiatov