-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download model refactor #75
Conversation
@@ -7,6 +7,9 @@ | |||
from torch.backends import cudnn as cudnn | |||
from tqdm import tqdm | |||
|
|||
from rt_gene.download_tools import download_external_landmark_models | |||
download_external_landmark_models() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this cannot be moved in the __init__
as the SFDDetector import below requires the models to be existing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you quite rightly thought - this is probably the least "nice" bit about this.
We have already modified the SFD detector to add in rospkg - could we not modify it further to make this less "hacky"?
We could further improve this by only downloading the models once they are required, but I think this adds quite a bit of complexity and would be prone to mistakes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I whole heartidly agree with this general pull commit, but is it worth altering the SFD detector to keep everything neat and tidy?
@@ -7,6 +7,9 @@ | |||
from torch.backends import cudnn as cudnn | |||
from tqdm import tqdm | |||
|
|||
from rt_gene.download_tools import download_external_landmark_models | |||
download_external_landmark_models() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you quite rightly thought - this is probably the least "nice" bit about this.
We have already modified the SFD detector to add in rospkg - could we not modify it further to make this less "hacky"?
Alright, what do we think after the latest commit @ahmed-alhindawi? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
w00p.
Looks wonderful, thanks for doing that.
Fix #71