protocol: follow strict datatype in TJsonProtocol, fixes #71 #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
==========================================
+ Coverage 80.79% 80.86% +0.07%
==========================================
Files 35 35
Lines 3540 3527 -13
==========================================
- Hits 2860 2852 -8
+ Misses 680 675 -5
Continue to review full report at Codecov.
|
iamsudip
commented
Sep 20, 2019
ethe
requested changes
Sep 20, 2019
iamsudip
commented
Sep 23, 2019
|
|
||
| if ttype == TType.MAP: | ||
| return map_to_json(val, spec) | ||
| TTYPE_TO_JSONFUNC_MAP = { |
There was a problem hiding this comment.
@ethe Do you think with there is negative performance impact if we move to map from branching?
There was a problem hiding this comment.
I think there is not much impact here.
| if ttype in (TType.STRING, TType.BOOL): | ||
| return val | ||
|
|
||
| TTYPE_TO_OBJFUNC_MAP = { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.