Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable socket_timeout on unix_socket #83

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Conversation

ryerh
Copy link
Contributor

@ryerh ryerh commented Sep 9, 2019

The timeout param for rpc.make_client only works when user provides host:port, but ignored when user provides unix_socket.

This PR fixed it.

Could you bump a new version as soon as this PR is accepted? pls.

@codecov
Copy link

codecov bot commented Sep 9, 2019

Codecov Report

Merging #83 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #83   +/-   ##
=======================================
  Coverage   80.79%   80.79%           
=======================================
  Files          35       35           
  Lines        3540     3540           
=======================================
  Hits         2860     2860           
  Misses        680      680
Impacted Files Coverage Δ
thriftpy2/rpc.py 81.69% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce676f6...37fe536. Read the comment docs.

@ethe
Copy link
Member

ethe commented Sep 9, 2019

LGTM, thank you!

@ethe ethe merged commit 0ef31b8 into Thriftpy:master Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants