Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable include_package_data in setup.py #63

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

aisk
Copy link
Member

@aisk aisk commented Jun 4, 2019

The original problem is the .pyx and .pxd files was not packaged in current versions, so it's not possible for extending the cython based classes (cython need source files to compile) in another package besides thriftpy2.

I saw there was a MANIFEST.in,but the include_package_data is not set in setup.py, according to
setuptoos 's documents, it should be set to make MANIFEST to take efforts. And seems the package_data field is duplicated if we enable include_package_data.

@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #63 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   80.57%   80.57%           
=======================================
  Files          35       35           
  Lines        3480     3480           
=======================================
  Hits         2804     2804           
  Misses        676      676

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4b0030...2d40bac. Read the comment docs.

@ethe
Copy link
Member

ethe commented Jun 4, 2019

If you want to package thriftpy2 manually, using make build instead, mentioned that you need to install Cython correctly. I think make build has already processed the .pyx and .pxd file.

@aisk
Copy link
Member Author

aisk commented Jun 4, 2019

No, I want using thriftpy2 as a pip dependence, and extend some classes which was written in cython in another package.

@aisk
Copy link
Member Author

aisk commented Jun 4, 2019

And I think it's a bug that MANIFEST.in was there and take no efforts.

@ethe
Copy link
Member

ethe commented Jun 4, 2019

Could you please tell me how I can reproduce your issue?

@aisk
Copy link
Member Author

aisk commented Jun 4, 2019

Running pip install thriftpy2 to install latest thriftpy2, and take a look at site-packages folder, the pyx files was gone, only the .so exists. If we want subclass a cython class, the pyx must exists.

Install my branch using pip install git+https://github.com/aisk/thriftpy2.git@fix-package-data, the pyx exists as expected.

@ethe
Copy link
Member

ethe commented Jun 4, 2019

That's true, thank you.

@ethe ethe merged commit 6d3036f into Thriftpy:master Jun 4, 2019
@aisk aisk deleted the fix-package-data branch June 4, 2019 06:43
@aisk
Copy link
Member Author

aisk commented Jun 4, 2019

Hi @ethe , another question, what's the release schedule of thriftpy2? My package is reply on this and #60. It's nice to not having a internal fork to manage this.

@ethe
Copy link
Member

ethe commented Jun 4, 2019

@aisk I will release it later this week, unfortunately there is not a release schedule of thriftpy2 yet.

@aisk
Copy link
Member Author

aisk commented Jun 4, 2019

Cool, thanks for help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants