Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Added Support For Apache JSON and Binary Data" #157

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

ethe
Copy link
Member

@ethe ethe commented Jan 21, 2021

Reverts #139 for a quick recovery via #156 , Apache JSON protocol could be merged again as a single merge request later.

@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #157 (c63bbb2) into master (24b3341) will decrease coverage by 0.90%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
- Coverage   84.23%   83.33%   -0.91%     
==========================================
  Files          44       43       -1     
  Lines        4143     3931     -212     
==========================================
- Hits         3490     3276     -214     
- Misses        653      655       +2     
Impacted Files Coverage Δ
thriftpy2/contrib/aio/rpc.py 84.44% <ø> (ø)
thriftpy2/protocol/__init__.py 86.66% <ø> (-0.84%) ⬇️
thriftpy2/protocol/json.py 82.75% <ø> (-13.89%) ⬇️
thriftpy2/contrib/aio/protocol/binary.py 57.80% <25.00%> (+2.06%) ⬆️
thriftpy2/contrib/aio/protocol/compact.py 60.98% <100.00%> (+0.81%) ⬆️
thriftpy2/protocol/binary.py 90.31% <100.00%> (+1.05%) ⬆️
thriftpy2/protocol/compact.py 82.26% <100.00%> (-2.14%) ⬇️
thriftpy2/thrift.py 90.39% <100.00%> (ø)
thriftpy2/transport/buffered/__init__.py 95.12% <0.00%> (-2.44%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24b3341...c63bbb2. Read the comment docs.

@ethe ethe merged commit ac2b5e2 into master Jan 21, 2021
@ethe ethe deleted the revert-139-master branch November 10, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant