Send TApplicationException to client if raised #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
==========================================
+ Coverage 84.13% 84.23% +0.10%
==========================================
Files 44 44
Lines 4141 4143 +2
==========================================
+ Hits 3484 3490 +6
+ Misses 657 653 -4
Continue to review full report at Codecov.
|
ethe
approved these changes
Jan 15, 2021
aisk
force-pushed
the
handle-tapplication
branch
from
77529d2
to
346c302
Compare
aisk
force-pushed
the
handle-tapplication
branch
from
346c302
to
df80fbb
Compare
ethe
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
TApplicationExceptionraised from user's codes (RPC handler) will be treated as normal Pyhthon error. But if we can send it to client, it will be convenient to use it to handle any unknown exceptions.