add support for custom headers for HTTP #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
==========================================
+ Coverage 84.05% 84.13% +0.07%
==========================================
Files 44 44
Lines 4133 4141 +8
==========================================
+ Hits 3474 3484 +10
+ Misses 659 657 -2
Continue to review full report at Codecov.
|
|
Hi, please add a test case to this feature, thanks. |
aisk
reviewed
Nov 13, 2020
aisk
reviewed
Nov 16, 2020
ethe
approved these changes
Nov 17, 2020
aisk
reviewed
Nov 17, 2020
aisk
reviewed
Nov 17, 2020
aisk
approved these changes
Nov 17, 2020
|
LGTM, approved, thanks for the contribution @ermeaney ! But I saw there was a conflict, I think you should rebase the commits so we can merge it. |
Add THttpHeaderFactory to allow client to send custom headers fix flake8 errors THttpClient constructor defaults THttpHeaderFactory to None THttpHeaderFactory get_headersreturns empty dict() instead of None updates from PR review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our thrift implementation needs to have some custom headers in the HTTP call, and since the implementation was almost there I updated the make_client function to support it