Rename socket_timeout to timeout for compatibility #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
==========================================
+ Coverage 79.7% 79.71% +0.01%
==========================================
Files 43 43
Lines 3902 3905 +3
==========================================
+ Hits 3110 3113 +3
Misses 792 792
Continue to review full report at Codecov.
|
aisk
approved these changes
Jan 19, 2020
|
Maybe a little test case on this should be cool? |
Signed-off-by: aiudirog <aiudirog@gmail.com>
|
@aisk I mocked out TAsyncSocket and validated that the arguments are handled as expected. I also squashed the commits since I had some small hiccups with flake8 and Py3.5. |
|
Great job 👍 LGTM |
|
I'll go ahead and merge this in. Thanks! |
|
👍 good job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard
make_client()uses thetimeoutargument to specify the socket timeout whereas the asynciomake_client()calls itsocket_timeout. Since AIOHappyBase handles both, it leads to awkward dispatch issue where I have to rewrite the argument for one.This PR deprecates
socket_timeoutin favor of justtimeoutso that the asyncmake_client()matches the standard one. I chose this and not the other way around so it would have the least impact on existing code, even though thesocket_timeoutname is more descriptive and probably better.