This repository has been archived by the owner on Dec 10, 2018. It is now read-only.
Added service multiplexing support. #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 22, 2015 17:16
This introduces a `TMultiplexingProcessor` class which extends `TProcessor`. This adds the ability for developers to develop services that implement multiple Thrift interfaces. It is inspired by the `TMultiplexedProcessor` from the Thrift Java library.
|
👍 @maralla |
|
|
||
| def register_processor(self, processor): | ||
| service = processor._service | ||
| name = service.__name__ |
There was a problem hiding this comment.
It may be better to use a more unique name to avoid collision of services with the same name but implementing different methods. Maybe the module name and the service class name?
There was a problem hiding this comment.
Good call, I'll fix that.
|
Somehow got my changes out of sync with develop. Going to close this PR and open a new one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a
TMultiplexingProcessorclass which extendsTProcessor. This adds the ability for developers to develop services that implement multiple Thrift interfaces. It is inspired by theTMultiplexedProcessorfrom the Thrift Java library.Example here: http://stackoverflow.com/questions/19614648/service-multiplexing-using-apache-thrift