Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pseudo-instruction JR #43

Closed
rmnattas opened this issue Jul 8, 2019 · 5 comments
Closed

Pseudo-instruction JR #43

rmnattas opened this issue Jul 8, 2019 · 5 comments
Labels

Comments

@rmnattas
Copy link
Contributor

rmnattas commented Jul 8, 2019

In page 110 of the RISC-V Specifications the format for the pseudo-instruction jr is jr rs.

When I used jr ra in RARS I got the following error:
Too few or incorrectly formatted operands. Expected: jr t0, -100

I think keeping the format jr t0, -100 would be beneficial but also supporting the official one is important.

Where does RARS handle pseudo-instruction in the source code?

@TheThirdOne TheThirdOne added the bug label Jul 9, 2019
@TheThirdOne
Copy link
Owner

TheThirdOne commented Jul 9, 2019

I thought I copied all of the specified psuedo instructions, but it appears I was wrong.

This is handled at

rars/PseudoOps.txt

Lines 105 to 106 in 6afb286

jr t0, -100 ;jalr x0, RG1, VL2;#Jump Register: Jump to address in t0
jalr t0, -100 ;jalr x1, RG1, VL2;#Jump And Link Register: Jump to address in t0 and set the return address to ra

Its a two line addition. I can push it up in a few hours.

@rmnattas
Copy link
Contributor Author

rmnattas commented Aug 7, 2019

@TheThirdOne Would it be possible to make a new release for RARS? I just noticed that the latest release does not include this bug fix but the pre-release does. We would have a group of students download RARS soon (some already did) and we would like for this fix to be included.

@TheThirdOne
Copy link
Owner

@rmnattas, I definitely could make a new release. The reason I made the continuously updated per-release is to make it easy to get access to the latest bugfixes. The main releases are then intended to each have significant developments over the last.

There have been a few small psuedo-op improvemnts and progress on two outstanding issues since v1.3, but thats a pretty small set. What is the reason you are uncomfortable with using the continuous release? If possible, I would like to improve the continuous release system so it could satisfy this kind of request.

@rmnattas
Copy link
Contributor Author

rmnattas commented Aug 7, 2019

@TheThirdOne We are providing the repo link to students before the terms begin and they mostly will be downloading the latest release instead of the pre-release, and we would prefer if there's a version number (i.e. 1.3.1) to specify and work on.

@TheThirdOne
Copy link
Owner

v1.3.1 now exists.

esperz2019 pushed a commit to esperz2019/rars that referenced this issue Jul 17, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants