Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #2496

Merged
merged 1 commit into from
May 8, 2020
Merged

Update dependencies #2496

merged 1 commit into from
May 8, 2020

Conversation

johanstokking
Copy link
Member

Summary

Update dependencies

Changes

  • Update dependencies

Notes for Reviewers

No functional changes

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md. The target branch is set to master if the changes are fully compatible with existing API, database, configuration and CLI.
  • Testing: The changes are covered with unit tests. The changes are tested manually as well.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@johanstokking johanstokking added the tooling Development tooling label May 7, 2020
@johanstokking johanstokking added this to the May 2020 milestone May 7, 2020
@johanstokking johanstokking self-assigned this May 7, 2020
@johanstokking johanstokking added dependencies Pull requests that update a dependency file and removed tooling Development tooling labels May 7, 2020
@johanstokking johanstokking mentioned this pull request May 7, 2020
Closed
10 tasks
@johanstokking johanstokking added the blocking Another issue or pull request is waiting for this label May 7, 2020
@johanstokking
Copy link
Member Author

The errors are not unwrapping in pkg/errors/web; I wonder how that's related to the dependency updates. Echo is not updated.

@rvolosatovs
Copy link
Contributor

#2417 (comment)

@johanstokking johanstokking self-assigned this May 7, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 73.17% when pulling 5c954d9 on feature/update-deps into c637d93 on master.

@rvolosatovs rvolosatovs removed their assignment May 8, 2020
@johanstokking johanstokking merged commit cf19a2b into master May 8, 2020
@johanstokking johanstokking deleted the feature/update-deps branch May 8, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvolosatovs rvolosatovs rvolosatovs approved these changes

@adriansmares adriansmares Awaiting requested review from adriansmares

@htdvisser htdvisser Awaiting requested review from htdvisser

@KrishnaIyer KrishnaIyer Awaiting requested review from KrishnaIyer

Assignees

@johanstokking johanstokking

Labels
blocking Another issue or pull request is waiting for this dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
May 2020
Development

Successfully merging this pull request may close these issues.
3 participants
@johanstokking @rvolosatovs @coveralls