Factory Functions and the Module Pattern lesson: Change broken link #28327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CouchofTomato
approved these changes
Jul 1, 2024
The header contains a dash '-' that causes the automatically generated fragment to don't match the link to the header: generated fragment link: '#the-module-pattern---iifes' correct link: '#the-module-pattern-iifes' By using the correct link as an id in the header both links will match
MaoShizhong
dismissed
their stale review
Just realised the id/fragment change is redundant
MaoShizhong
requested changes
Jul 2, 2024
javascript/organizing_your_javascript_code/factory_functions_and_module_pattern.md
Outdated
Show resolved
Hide resolved
MaoShizhong
approved these changes
Jul 2, 2024
9 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
The "Factory Functions and the Module Pattern" lesson had a broken link in the "Describe IIFEs and what they stand for" bullet point.
This PR
Issue
Closes #28324
Additional Information
Pull Request Requirements
location of change: brief description of changeformat, e.g.Intro to HTML and CSS lesson: Fix link textBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection