Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby On Rails: Update link text #28312

Conversation

SeanAverS
Copy link
Contributor

Because

Update link text for improved accessibility

This PR

  • In the Working with External APIs lesson, update the link text on lines 9, 86, 92, 105, 130, 132, and 133

Issue

Related to #28290

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Ruby on Rails Involves the Ruby on Rails course label Jun 29, 2024
@SeanAverS
Copy link
Contributor Author

Hi @MaoShizhong, let me know if you would like me to fix the linting errors 👍

Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could fix up the lint errors, that would be amazing. Should be fine with one or two passes of the fix script, then perhaps a couple of manual fixes after. Let me know if you run into any issues with this.

Also two little errors on my part, if you could make those changes too? Thanks!

ruby_on_rails/apis/working_with_external_apis.md Outdated Show resolved Hide resolved
ruby_on_rails/apis/working_with_external_apis.md Outdated Show resolved Hide resolved
@SeanAverS SeanAverS force-pushed the rails-pathway-provide-desc-link-text branch from ecc0367 to e9e8b8b Compare July 1, 2024 05:20
@SeanAverS
Copy link
Contributor Author

My bad. I removed the second last commit because the title was wrong

Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the lint errors and typos.

There's just one small merge conflict to resolve, since a change was made to a link that says Chrome's Rest Client which now says Postman, and your fork hadn't been updated to include that change and the line in question is included in the commit diff.

If you can resolve it by changing the link name to Postman, that should put everything in sync and happy.

@MaoShizhong
Copy link
Contributor

@SeanAverS looks like the merge conflict was preventing some lint errors from flagging. Would you be happy to fix the remaining ones, then we should be good to merge once they're done? Should be fixable with the script, then the "heading structure" error with ### Conclusion can be fixed by changing it to a level 4 heading i.e. #### Conclusion

@SeanAverS
Copy link
Contributor Author

Apologies for the excessive commits, never had to deal with merge conflicts before. Thank you for your patience @MaoShizhong 🙏

Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries about the commits, they're hardly excessive. I mean, take a look at #27953 (there have been PRs with way more commits too). Most of us usually squash when merging anyway (nothing you need to do).

And also no worries about the merge conflict. There's always a first time, so it's a learning experience. Sometimes you're lucky and it's super simple, sometimes it gets real funky. But that's why we're here to help, and if anything, it's on us if we miss stuff in review 😅

ruby_on_rails/apis/working_with_external_apis.md Outdated Show resolved Hide resolved
Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>
@SeanAverS
Copy link
Contributor Author

Wow #27953 is a lot of commits 😆

Thanks again for your help @MaoShizhong!

Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Even that PR isn't really that many commits. Around all sorts of OSS repos you'll get PRs with a lot of commits. Don't worry about commit count, only what you believe is intuitive for an individual commit, and that commits contain necessary stuff (e.g. requested changes etc.)

@MaoShizhong MaoShizhong merged commit f7f42c0 into TheOdinProject:main Jul 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Ruby on Rails Involves the Ruby on Rails course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants