-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby On Rails: Update link text #28312
Ruby On Rails: Update link text #28312
Conversation
Hi @MaoShizhong, let me know if you would like me to fix the linting errors 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you could fix up the lint errors, that would be amazing. Should be fine with one or two passes of the fix script, then perhaps a couple of manual fixes after. Let me know if you run into any issues with this.
Also two little errors on my part, if you could make those changes too? Thanks!
ecc0367
to
e9e8b8b
Compare
My bad. I removed the second last commit because the title was wrong |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the lint errors and typos.
There's just one small merge conflict to resolve, since a change was made to a link that says Chrome's Rest Client
which now says Postman
, and your fork hadn't been updated to include that change and the line in question is included in the commit diff.
If you can resolve it by changing the link name to Postman
, that should put everything in sync and happy.
@SeanAverS looks like the merge conflict was preventing some lint errors from flagging. Would you be happy to fix the remaining ones, then we should be good to merge once they're done? Should be fixable with the script, then the "heading structure" error with |
….com/SeanAverS/curriculum into rails-pathway-provide-desc-link-text
Apologies for the excessive commits, never had to deal with merge conflicts before. Thank you for your patience @MaoShizhong 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries about the commits, they're hardly excessive. I mean, take a look at #27953 (there have been PRs with way more commits too). Most of us usually squash when merging anyway (nothing you need to do).
And also no worries about the merge conflict. There's always a first time, so it's a learning experience. Sometimes you're lucky and it's super simple, sometimes it gets real funky. But that's why we're here to help, and if anything, it's on us if we miss stuff in review 😅
Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>
Wow #27953 is a lot of commits 😆 Thanks again for your help @MaoShizhong! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Even that PR isn't really that many commits. Around all sorts of OSS repos you'll get PRs with a lot of commits. Don't worry about commit count, only what you believe is intuitive for an individual commit, and that commits contain necessary stuff (e.g. requested changes etc.)
Because
Update link text for improved accessibility
This PR
Working with External APIs
lesson, update the link text on lines 9, 86, 92, 105, 130, 132, and 133Issue
Related to #28290
Additional Information
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section