Update to installations.md #28094
Closed
Update to installations.md #28094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in line 343 i have added the text in round brackets. i update because an answer i saw in the #wsl-help chat at the by Scheals.
github-actions
bot
added
the
Content: Foundations
xandora
reviewed
Jun 4, 2024
There was a problem hiding this comment.
Unfortunately, the answer here isn't quite this simple. On my fresh Windows 10 install, my only Ubuntu option in Terminal has the Ubuntu icon. This could be confusing for someone if they were expecting to click the Penguin icon, and they only saw an Ubuntu icon.
|
so should we also find what is done on win8 and edit acordingly or is it just not a worthwhile commit? |
|
@xandora is this PR something that still needs further action? Or is it something we can close and leave the lesson content as is? |
|
I think we'd probably get more questions about what to do if you don't have the Penguin icon. We should leave the lesson as it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
i updated an instraction because an answer i saw in the #wsl-help chat at the by Scheals. it works
This PR
in line 343 i have added the text in round brackets
Issue
Closes #XXXXX
Additional Information
Pull Request Requirements
location of change: brief description of changeformat, e.g.Intro to HTML and CSS lesson: Fix link textBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection