ES6 Modules: Clarified string declaration in import statements #28051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaoShizhong
reviewed
May 25, 2024
| @@ -83,6 +83,7 @@ export { functionOne }; | |||
|
|
|||
| ```javascript | |||
| // another JS file | |||
| // Note: Only use single quote (') or double quote (") for import statements | |||
There was a problem hiding this comment.
Possibly could start with "You can only use..." To make it explicit it's not just "you should as best practice" but actually "you cannot use template strings for the import"?
Only a small nit but I think it'll be clearer
There was a problem hiding this comment.
@MaoShizhong just made the change. Let me know what you think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
Added a note to inform users to only use quote(') or double quote(") for import statements. If you try to call and import statement using a template literal (`) it will not work. In the MDN tutorial on strings they mention pick one string declaration method and stick to it. This may cause learners to try calling import statements with template literals and wondering why something is wrong.
This PR
added a comment in the import statement code block mentioning to only use quote(') or double quote(") for import statements
Issue
Closes #28049
Additional Information
first pr, go easy on me
Pull Request Requirements
location of change: brief description of changeformat, e.g.Intro to HTML and CSS lesson: Fix link textBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection