-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack: Rewrite lesson with in-house tutorial (alongside ES6 Modules rewrite) #27961
Open
MaoShizhong
wants to merge
30
commits into
TheOdinProject:main
Choose a base branch
from
MaoShizhong:feature/webpack-lesson-rewrite
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Webpack: Rewrite lesson with in-house tutorial (alongside ES6 Modules rewrite) #27961
MaoShizhong
wants to merge
30
commits into
TheOdinProject:main
from
MaoShizhong:feature/webpack-lesson-rewrite
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lesson structure and key concepts mostly raised by Advait. Co-authored-by: advait0603 <advaitlinux11@gmail.com>
Uses AE instead of BE spelling.
Co-authored-by: advait0603 <advaitlinux11@gmail.com>
MaoShizhong
added
Type: Existing Lesson
Involves an existing lesson or lessons
Content: JavaScript
Involves the JavaScript course
labels
May 11, 2024
This was referenced May 11, 2024
Things I would like thoughts on in particular:
Any other aspects as well. The above is just what stuck around my mind most during writing. |
7 tasks
Npm scripts now covered in the new Revisiting Webpack lesson that will come immediately after this project.
MaoShizhong
added
the
Status: Do Not Merge
This PR should not be merged until further notice
label
Jun 30, 2024
7761cookie
reviewed
Jun 30, 2024
To address any questions about "why not just link CSS in the HTML"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Content: JavaScript
Involves the JavaScript course
Status: Do Not Merge
This PR should not be merged until further notice
Type: Existing Lesson
Involves an existing lesson or lessons
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
The current Webpack lesson is a known pain point in the curriculum journey, primarily due to the sudden increase in complexity and steps of tooling, coupled with how much of the learning is left to external resources. These external resources limit the cohesiveness of teaching material, and can prove troublesome in the learning process when each resource includes a few unnecessary tidbits that can easily throw learners off (such as multiple entry points in the webpack official guides when learning about html-webpack-plugin). They also are frequently aimed at people who may know a little more about bundlers already, or are following a different course/tutorial. Thus, things often feel disjointed with the TOP curriculum.
While improving the Webpack lesson itself is the primary focus, it was also identified that the preceding ES6 modules lesson is fairly coupled with it, as Webpack and bundlers are introduced there instead of the Webpack lesson.
The order of the ES6 modules lesson was also identified as a little odd, and the order and flow could be improved by focusing on ES6 modules as a primary topic straight away, then introducing bundlers and Webpack in their own separate lesson.
General plan:
This PR
Issue
Related to #26976
Related to #26977
(closed by #27953)
Additional Information
This will be something to merge alongside 3 other PRs:
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section