-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS Webpack: Add webpack lesson content #26381
JS Webpack: Add webpack lesson content #26381
Conversation
Covers general bundling, loaders and HtmlWebpackPlugin. Adjusts assignment links with new resource and NBs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments that would attention but this looks great overall!
Adjust existing and add new knowledge checks based on new lesson content.
Dev/prod mode differences and concerns when webpack warns that a mode Whilst optional and just quality of life, I believe this to be a very |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks great!
Because
Adds content to the Webpack lesson to introduce how webpack actually works with loaders/plugins/rules and also why they might be needed.
The current lesson does not provide much detail and dives straight into the webpack official tutorials which in my honest opinion, both leave a lot to be desired and also have very often left people in the discord server mightily confused over what things are, what they're for and why they're even needed (especially with how complicated it all looks vs the simple html/css/js they had been doing until then).
The tutorials don't explain the "why" very much, and also demonstrate some practices like serving a dev server from dist instead of src, and not showing how to use html-webpack-plugin with templates. This has led to a lot of people having problems either caused by incorrect/inappropriate usage of things (e.g. multiple entry points when not needed and combined with circular dependencies), and/or had their lives vastly improved when they discover how to actually use something more appropriately.
The proposed content and changes seek to provide a better intro to these concepts and tools, particularly in a way that would benefit the rest of the course's projects more directly.
This PR
Issue
Closes #26214
Additional Information
@ManonLef and @Baguirre03 both expressed an interest in helping with improving the lesson content here.
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section