Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media Queries #33

Closed
sprankhub opened this issue Feb 26, 2016 · 2 comments · Fixed by #37
Closed

Media Queries #33

sprankhub opened this issue Feb 26, 2016 · 2 comments · Fixed by #37
Labels
enhancement

Comments

@sprankhub
Copy link
Collaborator

The logic in the rwd theme is always max-width: 770px and min-width: 771px. Hence, the entries under https://github.com/TheExtensionLab/MegaMenu/blob/master/skin/frontend/base/default/scss/theextensionlab/megamenu/_settings.scss should be updated.
@JamesAnelay
Copy link
Member

Sorry for the late reply - missed the notification on this one.

If I understand correctly - what your saying is that the "769px" and "770px" values in this file are off by 1 and should be increased by 1 px correct?

If so I think that should be fine for me to update without causing anybody any significant backwards compatability issues and will do so over the next few days. Thanks!

@sprankhub
Copy link
Collaborator Author

Exactly!

JamesAnelay added a commit that referenced this issue Mar 8, 2016
@JamesAnelay
Correct RWD default breakpoints - fixes #33
5fcb661
@JamesAnelay JamesAnelay mentioned this issue Mar 8, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1.5.3 - Multiple Fixes TheExtensionLab/MegaMenu
2 participants
@sprankhub @JamesAnelay