Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Utah tax logic #24

Merged
merged 20 commits into from
Feb 10, 2023
Merged

Add Utah tax logic #24

merged 20 commits into from
Feb 10, 2023

Conversation

rickecon
Copy link
Collaborator

This PR adds the files for the Utah state income tax logic. It does the following.

  • Adds a fiscalsim_us/parameters/gov/states/ut/README.md that details specific approaches taken with the Utah tax form.
  • Adds all the Utah parameters to the ``fiscalsim_us/parameters/gov/states/ut` directory.
  • Adds a fiscalsim_us/variables/gov/states/README.md that details the steps to adding a state tax logic to the model.
  • Adds all the Utah variables to the ``fiscalsim_us/parameters/gov/states/ut` directory.
  • Updates the state_income_tax.py and state_income_tax_before_refundable_credits.py files with the appropriate Utah variables in the /fiscalsim_us/variables/gov/states/tax/income/ directory.
  • Updates the household_refundable_tax_credits.py and household_tax_before_refundable_credits.py files with the appropriate Utah variables in the /fiscalsim_us/variables/household/income/household/ directory.
  • Sets the default value to False in /fiscalsim_us/variables/household/expense/health/has_marketplace_health_coverage.py
  • black and linecheck formatted all new .py files.
  • make documentation command still errors out. I need to fix the documentation.

@rickecon
Copy link
Collaborator Author

Three tests are failing. The tests in premium_tax_credit.yaml are probably just failing because the default is now False. And the failing test in ut_taxpayer_credit_max.yaml is probably just due to the changes this PR makes to Utah.

fiscalsim_us/tests/policy/baseline/gov/irs/credits/premium_tax_credit/premium_tax_credit.yaml FF
fiscalsim_us/tests/policy/baseline/gov/states/ut/tax/income/credits/ut_taxpayer_credit_max.yaml F.

I need to add all the tests for this PR. And I need to add a Utah notebook.

@rickecon
Copy link
Collaborator Author

I still don't have a fix for the Check version CI test issue. So I am just updating version directly still. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant