Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use override keyword when possible #972

Closed
wants to merge 1 commit into from

Conversation

feliwir
Copy link
Contributor

@feliwir feliwir commented Aug 8, 2023

  • Remove virtual keyword when not required
  • Use override keyword when a function overrides

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2023

Codecov Report

Patch coverage: 3.60% and no project coverage change.

Comparison is base (e1609b2) 2.67% compared to head (b6e4655) 2.67%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop    #972   +/-   ##
=======================================
  Coverage     2.67%   2.67%           
=======================================
  Files          822     822           
  Lines        89290   89290           
  Branches     14799   14799           
=======================================
  Hits          2387    2387           
  Misses       86559   86559           
  Partials       344     344           
Files Changed Coverage Δ
src/game/client/anim2d.h 0.00% <0.00%> (ø)
src/game/client/baseheightmap.h 0.00% <0.00%> (ø)
src/game/client/camerashakesystem.h 0.00% <0.00%> (ø)
src/game/client/crashpreferences.h 0.00% <0.00%> (ø)
src/game/client/display.h 0.00% <0.00%> (ø)
src/game/client/displaystring.h 0.00% <ø> (ø)
src/game/client/draw/drawable.h 0.00% <0.00%> (ø)
src/game/client/draw/tintenvelope.h 0.00% <0.00%> (ø)
src/game/client/draw/w3ddebrisdraw.h 0.00% <0.00%> (ø)
src/game/client/draw/w3ddefaultdraw.h 0.00% <0.00%> (ø)
... and 254 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xezon
Copy link
Contributor

xezon commented Aug 8, 2023

I do not like this. I personally would like it to keep virtual always.

@feliwir feliwir closed this Sep 13, 2024
@xezon
Copy link
Contributor

xezon commented Sep 14, 2024

But adding override everywhere necessary is good.

@feliwir
Copy link
Contributor Author

feliwir commented Sep 14, 2024

I closed the PRs for now since they‘re pretty outdated. My focus for now is to get standalone working (to some degree).
I’ll pick those up again later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants