Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix game crash when a shadow buffer limit is exceeded #1101

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

xezon
Copy link
Contributor

@xezon xezon commented Feb 10, 2024

This change fixes game crashes from exceeding the limits of MAX_VB_SIZES, MAX_IB_SIZES and MAX_NUMBER_SLOTS.

MAX_NUMBER_SLOTS is exceeded in the original game when more than 512 Scorpion tanks are rendered in the scene.

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (cfa005f) 2.53% compared to head (6e21d1b) 2.53%.

Files Patch % Lines
...tform/w3dengine/client/shadow/w3dbuffermanager.cpp 0.00% 8 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1101      +/-   ##
===========================================
- Coverage     2.53%    2.53%   -0.01%     
===========================================
  Files          949      949              
  Lines       110299   110307       +8     
  Branches     18881    18885       +4     
===========================================
  Hits          2800     2800              
- Misses      107095   107103       +8     
  Partials       404      404              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The game crashes when a certain 3D Shadow limit is exceeded
2 participants