Skip to content
This repository has been archived by the owner on Jun 18, 2022. It is now read-only.

Better internal error catching #5

Merged
merged 4 commits into from
Nov 20, 2020
Merged

Better internal error catching #5

merged 4 commits into from
Nov 20, 2020

Conversation

ThatXliner
Copy link
Owner

As described on roadmap #3

This will not catch all error but only up to LarkError.

@sourcery-ai
Copy link

sourcery-ai bot commented Nov 20, 2020

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 1.73%.

Quality metrics Before After Change
Complexity 1.82 ⭐ 2.20 ⭐ 0.38 👎
Method Length 37.43 ⭐ 40.43 ⭐ 3.00 👎
Working memory 6.93 🙂 7.17 🙂 0.24 👎
Quality 80.67% 78.94% -1.73% 👎
Other metrics Before After Change
Lines 87 91 4
Changed files Quality Before Quality After Quality Change
lark_shell.py 80.67% ⭐ 78.94% ⭐ -1.73% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@ThatXliner ThatXliner merged commit 27c65db into master Nov 20, 2020
@ThatXliner ThatXliner deleted the better-error branch November 20, 2020 18:07
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant