Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Tweak default colors for RichHandler #2825

Closed
alexprengere opened this issue Feb 22, 2023 · 3 comments · Fixed by #2858
Closed

[REQUEST] Tweak default colors for RichHandler #2825

alexprengere opened this issue Feb 22, 2023 · 3 comments · Fixed by #2858
Labels
accepted Task was accepted

Comments

@alexprengere
Copy link
Contributor

Hello, first of all, thank you for rich! I use it in pretty much all my projects.

I have a very minor suggestion regarding the default colors for logging levels.
I know we can customize them using themes (and I already do!).
I use mostly info/warning/error levels for logging, and depending on the terminal used, warnings and errors render almost identically.

When googling "Python colored logs", the top solutions (in my case) use yellow-ish for warnings and red for errors.
Granted, many of the top results use coloredlogs, but in any case I see:

So I was wondering if you would be willing to tweak the default 'logging.level.warning' to something closer to yellow, to be more in line with this, and give a bit more distinction to warnings and errors.
Anyway, I am perfectly happy with customization through themes!

@github-actions
Copy link

We found the following entry in the FAQ which you may find helpful:

Feel free to close this issue if you found an answer in the FAQ. Otherwise, please give us a little time to review.

This is an automated reply, generated by FAQtory

@willmcgugan
Copy link
Collaborator

Sure. I would accept a PR for that...

Copy link

github-actions bot commented Jul 1, 2024

I hope we solved your problem.

If you like using Rich, you might also enjoy Textual

mhxion added a commit to uhd-urz/elAPI that referenced this issue Aug 27, 2024
Typer already depends on rich. To use the latest rich version, we define 'rich = "^13.8.0"' ourselves. Rich v13.8.0 comes with some important fixes that concern us. See: https://github.com/Textualize/rich/releases/tag/v13.8.0, Textualize/rich#2825.
mhxion added a commit to uhd-urz/elAPI that referenced this issue Aug 27, 2024
Typer already depends on rich. To use the latest rich version, we define 'rich = "^13.8.0"' ourselves. Rich v13.8.0 comes with some important fixes that concern us. See: https://github.com/Textualize/rich/releases/tag/v13.8.0, Textualize/rich#2825.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Task was accepted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants