feat: add water droplet icon beside the Thirst Bar #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdrueckert
requested changes
Oct 15, 2021
There was a problem hiding this comment.
I feel like it helps associating the contents of this file with what you can see in-game if the elements are in the same "order", aka if the icon comes first and then the bar.
Further, I think we should make the horizontal placement of the bar relative to the icon. Thus, they'll always have the same offset even if you decide to move it further right or left by adjusting the icon's horizontal placement. I would recommend the following for the bar:
"position-left": {
"target": "LEFT",
"widget": "thirstIcon",
"offset": 45
},
Co-authored-by: jdrueckert <jd.rueckert@googlemail.com>
Co-authored-by: jdrueckert <jd.rueckert@googlemail.com>
|
thank you. all have been revised as suggested. |
jdrueckert
reviewed
Oct 18, 2021
jdrueckert
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add water droplet icon indicator on the left of the thirst bar
