feat: split GenomeAuthoritySystem based on modules #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The integration with Genome and BasicCrafting is optional for SimpleFarming. As a component system can only be loaded properly if all it's dependencies are also active, this means that the combined `GenomeAuthoritySystem` is only loaded if **both** Genome and BasicCrafting are active. By splitting the authority system into `GenomeExtensionAuthoritySystem` and `GenomeCraftingExtensionAuthoritySystem` each extension system can run with the minimal set of required modules. - `GenomeExtensionAuthoritySystem` (works if at least Genome is loaded) - `GenomeCraftingExtensionAuthoritySystem` (works if both Genome and Basic Crafting are loaded) Fixes #119
skaldarnar
added
Type: Improvement
|
Does this also fix #118? |
|
Doesn't look like the tests are fixed: see pipeline |
DarkWeird
approved these changes
Aug 16, 2021
…systems I don't really know what the effect of that is, but it kind of makes sense to use the annotation field to document the optional dependencies in a way that we can more easily pick them up when registering systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration with Genome and BasicCrafting is optional for SimpleFarming.
As a component system can only be loaded properly if all it's dependencies are also active, this means that the combined
GenomeAuthoritySystemis only loaded if both Genome and BasicCrafting are active.By splitting the authority system into
GenomeExtensionAuthoritySystemandGenomeCraftingExtensionAuthoritySystemeach extension system can run with the minimal set of required modules.GenomeExtensionAuthoritySystem(works if at least Genome is loaded)GenomeCraftingExtensionAuthoritySystem(works if both Genome and Basic Crafting are loaded)Fixes #119
Closes #103