fix(#116): Hard crash destroying Joshaberry Bush due to missing berryseed. #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berryseed added to atlas. The game would hard crash when destroying a Joshaberry Bush due to missing berryseed reference. === Bug: Terasology#116 === Known Issue(s): After destroying a Joshaberry Bush, its seed will be invisible/transparent and not visible to the player if it is on the ground. However, when having collected 2 or more, a number will appear in the inventory and when hovered over the name will be displayed. When planting the berry bush seed it will take much longer than other bushes to grow. === Test Configuration(s): displayVersion=alpha-20 engineVersion=5.1.0-SNAPSHOT Java: 11.0.11 in C:\Program Files\AdoptOpenJDK\jdk-11.0.11.9-hotspot Java VM: OpenJDK 64-Bit Server VM, version: 11.0.11+9 OS: Windows 8.1, arch: amd64, version: 6.3 GFX: nVidia GTX 1050Ti Driver 471.11 SimpleFarming-2.2.0-SNAPSHOT
… berryseed. berryseed added to atlas. The game would hard crash when destroying a Joshaberry Bush due to missing berryseed reference. === Bug: Terasology#116 === Known Issue(s): After destroying a Joshaberry Bush, its seed will be invisible/transparent and not visible to the player if it is on the ground. However, when having collected 2 or more, a number will appear in the inventory and when hovered over the name will be displayed. When planting the berry bush seed it will take much longer than other bushes to grow. === Test Configuration(s): displayVersion=alpha-20 engineVersion=5.1.0-SNAPSHOT Java: 11.0.11 in C:\Program Files\AdoptOpenJDK\jdk-11.0.11.9-hotspot Java VM: OpenJDK 64-Bit Server VM, version: 11.0.11+9 OS: Windows 8.1, arch: amd64, version: 6.3 GFX: nVidia GTX 1050Ti Driver 471.11 SimpleFarming-2.2.0-SNAPSHOT
jdrueckert
added
Category: Crash
jdrueckert
changed the title
jdrueckert
requested changes
Jul 12, 2021
There was a problem hiding this comment.
Please also add a texture to the texture atlas, otherwise the item will be invisible in-game as the field you added to the atlas definition will point to an "empty" part of the texture atlas.
It's sufficient if you simply copy the first texture in the texture atlas.
…sing berryseed. Removed "test"string from the BerrySeed and Berry as it may have been experimental in the previous commit. The game would hard crash when destroying a Joshaberry Bush due to missing or incorrect berryseed reference. Terasology#116 See JoshariasSurvival module to lower the growthStages min-max to speed up growth. displayVersion=alpha-20 engineVersion=5.1.0-SNAPSHOT Java: 11.0.11 in C:\Program Files\AdoptOpenJDK\jdk-11.0.11.9-hotspot Java VM: OpenJDK 64-Bit Server VM, version: 11.0.11+9 OS: Windows 8.1, arch: amd64, version: 6.3 GFX: nVidia GTX 1050Ti Driver 471.11 SimpleFarming-2.2.0-SNAPSHOT
|
Updated. Everything was a minor text change in the atlas. |
jdrueckert
requested changes
Jul 13, 2021
…sing berryseed. Renamed the Test* string from the seed and Bush in the atlas file. TestSeed prefab updated to use the correct berryseed. Fixes Terasology#116 Originally, the game would hard crash when destroying a Joshaberry Bush due to missing berryseed reference. nothing serious displayVersion=alpha-20 engineVersion=5.1.0-SNAPSHOT Java: 11.0.11 in C:\Program Files\AdoptOpenJDK\jdk-11.0.11.9-hotspot Java VM: OpenJDK 64-Bit Server VM, version: 11.0.11+9 OS: Windows 8.1, arch: amd64, version: 6.3 GFX: nVidia GTX 1050Ti Driver 471.11 SimpleFarming-2.2.0-SNAPSHOT
…otze/SimpleFarming into Fix116_berryseedCrash
jdrueckert
approved these changes
Jul 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
berryseed added to atlas. The game would hard crash when destroying a Joshaberry Bush due to missing berryseed reference.
Bug:
Fixes #116
Known Issue(s):
After destroying a Joshaberry Bush, its seed will be invisible/transparent and not visible to the player if it is on the
ground. However, when having collected 2 or more, a number will appear in the inventory and when hovered over the name will be displayed.
When planting the berry bush seed it will take much longer than other bushes to grow.
Test Configuration(s):
displayVersion=alpha-20
engineVersion=5.1.0-SNAPSHOT
Java: 11.0.11 in C:\Program Files\AdoptOpenJDK\jdk-11.0.11.9-hotspot
Java VM: OpenJDK 64-Bit Server VM, version: 11.0.11+9
OS: Windows 8.1, arch: amd64, version: 6.3
GFX: nVidia GTX 1050Ti Driver 471.11
SimpleFarming-2.2.0-SNAPSHOT