-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#116): Hard crash destroying Joshaberry Bush due to missing berryseed. #117
fix(#116): Hard crash destroying Joshaberry Bush due to missing berryseed. #117
Conversation
berryseed added to atlas. The game would hard crash when destroying a Joshaberry Bush due to missing berryseed reference. === Bug: Terasology#116 === Known Issue(s): After destroying a Joshaberry Bush, its seed will be invisible/transparent and not visible to the player if it is on the ground. However, when having collected 2 or more, a number will appear in the inventory and when hovered over the name will be displayed. When planting the berry bush seed it will take much longer than other bushes to grow. === Test Configuration(s): displayVersion=alpha-20 engineVersion=5.1.0-SNAPSHOT Java: 11.0.11 in C:\Program Files\AdoptOpenJDK\jdk-11.0.11.9-hotspot Java VM: OpenJDK 64-Bit Server VM, version: 11.0.11+9 OS: Windows 8.1, arch: amd64, version: 6.3 GFX: nVidia GTX 1050Ti Driver 471.11 SimpleFarming-2.2.0-SNAPSHOT
… berryseed. berryseed added to atlas. The game would hard crash when destroying a Joshaberry Bush due to missing berryseed reference. === Bug: Terasology#116 === Known Issue(s): After destroying a Joshaberry Bush, its seed will be invisible/transparent and not visible to the player if it is on the ground. However, when having collected 2 or more, a number will appear in the inventory and when hovered over the name will be displayed. When planting the berry bush seed it will take much longer than other bushes to grow. === Test Configuration(s): displayVersion=alpha-20 engineVersion=5.1.0-SNAPSHOT Java: 11.0.11 in C:\Program Files\AdoptOpenJDK\jdk-11.0.11.9-hotspot Java VM: OpenJDK 64-Bit Server VM, version: 11.0.11+9 OS: Windows 8.1, arch: amd64, version: 6.3 GFX: nVidia GTX 1050Ti Driver 471.11 SimpleFarming-2.2.0-SNAPSHOT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add a texture to the texture atlas, otherwise the item will be invisible in-game as the field you added to the atlas definition will point to an "empty" part of the texture atlas.
It's sufficient if you simply copy the first texture in the texture atlas.
…sing berryseed. Removed "test"string from the BerrySeed and Berry as it may have been experimental in the previous commit. The game would hard crash when destroying a Joshaberry Bush due to missing or incorrect berryseed reference. Terasology#116 See JoshariasSurvival module to lower the growthStages min-max to speed up growth. displayVersion=alpha-20 engineVersion=5.1.0-SNAPSHOT Java: 11.0.11 in C:\Program Files\AdoptOpenJDK\jdk-11.0.11.9-hotspot Java VM: OpenJDK 64-Bit Server VM, version: 11.0.11+9 OS: Windows 8.1, arch: amd64, version: 6.3 GFX: nVidia GTX 1050Ti Driver 471.11 SimpleFarming-2.2.0-SNAPSHOT
Updated. Everything was a minor text change in the atlas. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also adjust the occurrence of TestBerrySeed
in assets/prefabs/Testing/TestSeed.prefab
accordingly
…sing berryseed. Renamed the Test* string from the seed and Bush in the atlas file. TestSeed prefab updated to use the correct berryseed. Fixes Terasology#116 Originally, the game would hard crash when destroying a Joshaberry Bush due to missing berryseed reference. nothing serious displayVersion=alpha-20 engineVersion=5.1.0-SNAPSHOT Java: 11.0.11 in C:\Program Files\AdoptOpenJDK\jdk-11.0.11.9-hotspot Java VM: OpenJDK 64-Bit Server VM, version: 11.0.11+9 OS: Windows 8.1, arch: amd64, version: 6.3 GFX: nVidia GTX 1050Ti Driver 471.11 SimpleFarming-2.2.0-SNAPSHOT
…otze/SimpleFarming into Fix116_berryseedCrash
berryseed added to atlas. The game would hard crash when destroying a Joshaberry Bush due to missing berryseed reference.
Bug:
Fixes #116
Known Issue(s):
After destroying a Joshaberry Bush, its seed will be invisible/transparent and not visible to the player if it is on the
ground. However, when having collected 2 or more, a number will appear in the inventory and when hovered over the name will be displayed.
When planting the berry bush seed it will take much longer than other bushes to grow.
Test Configuration(s):
displayVersion=alpha-20
engineVersion=5.1.0-SNAPSHOT
Java: 11.0.11 in C:\Program Files\AdoptOpenJDK\jdk-11.0.11.9-hotspot
Java VM: OpenJDK 64-Bit Server VM, version: 11.0.11+9
OS: Windows 8.1, arch: amd64, version: 6.3
GFX: nVidia GTX 1050Ti Driver 471.11
SimpleFarming-2.2.0-SNAPSHOT