Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hard crash when destroying a Joshaberry Bush due to missing berryseed. #116

Closed
NicolaasJKotze opened this issue Jul 10, 2021 · 0 comments · Fixed by #117
Closed

Hard crash when destroying a Joshaberry Bush due to missing berryseed. #116

NicolaasJKotze opened this issue Jul 10, 2021 · 0 comments · Fixed by #117
Labels
Category: Crash Requests, Issues and Changes targeting unexpected terminations, segfaults, etc. Category: Gameplay Content Requests, Issues and Changes targeting gameplay mechanics and content Good First Issue Good for learners that are new to Terasology Size: S Small effort likely only affecting a single area and requiring little to no research Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Bug Issues reporting and PRs fixing problems

Comments

@NicolaasJKotze
Copy link
Contributor

Summary:

When a world is created with the Josharias Survival template, the game will crash to the desktop when the player destroy a Joshaberry Bush.

Configuration:

Game: v5.0.0, Alpha-20, build6, 2021-07-05
Launcher: 4.4.0
OS: Windows 8.1 x64, English

Steps:

  1. Start a game using Josharias Survival template.
  2. Once in the game, look for a Joshaberry Bush.
  3. Destroy the Joshaberry Bush.
    Observe: Game crash to desktop.
    Expectation: The player will receive a berry seed or something.

Other Tests:

  1. PASS: Destroying other bushes.

Log:

23:25:02.243 [main] ERROR o.t.t.BaseTintOverlayProducer - Image: SimpleFarming:SimpleFarming#berryseed not found
23:25:02.244 [main] ERROR o.t.engine.core.TerasologyEngine - Uncaught exception, attempting clean game shutdown
java.util.NoSuchElementException: No value present
	at java.base/java.util.Optional.get(Unknown Source)

image
@jdrueckert jdrueckert added Category: Crash Requests, Issues and Changes targeting unexpected terminations, segfaults, etc. Category: Gameplay Content Requests, Issues and Changes targeting gameplay mechanics and content Good First Issue Good for learners that are new to Terasology Size: S Small effort likely only affecting a single area and requiring little to no research Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Bug Issues reporting and PRs fixing problems labels Jul 10, 2021
NicolaasJKotze added a commit to NicolaasJKotze/SimpleFarming that referenced this issue Jul 11, 2021
@NicolaasJKotze
FIX Terasology#116 Hard crash missing berryseed
c2c76dd 
berryseed added to atlas. The game would hard crash when destroying a Joshaberry Bush due to missing berryseed reference.

=== Bug:
Terasology#116

=== Known Issue(s):
After destroying a Joshaberry Bush, its seed will be invisible/transparent and not visible to the player if it is on the ground. However, when having collected 2 or more, a number will appear in the inventory and when hovered over the name will be displayed.
When planting the berry bush seed it will take much longer than other bushes to grow.

=== Test Configuration(s):
displayVersion=alpha-20
engineVersion=5.1.0-SNAPSHOT
Java: 11.0.11 in C:\Program Files\AdoptOpenJDK\jdk-11.0.11.9-hotspot
Java VM: OpenJDK 64-Bit Server VM, version: 11.0.11+9
OS: Windows 8.1, arch: amd64, version: 6.3
GFX: nVidia GTX 1050Ti Driver 471.11
SimpleFarming-2.2.0-SNAPSHOT
NicolaasJKotze added a commit to NicolaasJKotze/SimpleFarming that referenced this issue Jul 11, 2021
@NicolaasJKotze
FIXED 116 Hard crash when destroying a Joshaberry Bush due to missing…
dc2848a 
… berryseed.

berryseed added to atlas. The game would hard crash when destroying a
Joshaberry Bush due to missing berryseed reference.

=== Bug:
Terasology#116

=== Known Issue(s):
After destroying a Joshaberry Bush, its seed will be
invisible/transparent and not visible to the player if it is on the
ground. However, when having collected 2 or more, a number will appear
in the inventory and when hovered over the name will be displayed.
When planting the berry bush seed it will take much longer than other
bushes to grow.

=== Test Configuration(s):
displayVersion=alpha-20
engineVersion=5.1.0-SNAPSHOT
Java: 11.0.11 in C:\Program Files\AdoptOpenJDK\jdk-11.0.11.9-hotspot
Java VM: OpenJDK 64-Bit Server VM, version: 11.0.11+9
OS: Windows 8.1, arch: amd64, version: 6.3
GFX: nVidia GTX 1050Ti Driver 471.11
SimpleFarming-2.2.0-SNAPSHOT
@NicolaasJKotze NicolaasJKotze mentioned this issue Jul 11, 2021
Merged
NicolaasJKotze added a commit to NicolaasJKotze/SimpleFarming that referenced this issue Jul 12, 2021
@NicolaasJKotze
fix(Terasology#116): Hard crash destroying Joshaberry Bush due to mis…
b27b106 
…sing berryseed.

Removed "test"string from the BerrySeed and Berry as it may have been
experimental in the previous commit.
The game would hard crash when destroying a Joshaberry Bush due to
missing or incorrect berryseed reference.

Terasology#116

See JoshariasSurvival module to lower the growthStages min-max to speed
up growth.

displayVersion=alpha-20
engineVersion=5.1.0-SNAPSHOT
Java: 11.0.11 in C:\Program Files\AdoptOpenJDK\jdk-11.0.11.9-hotspot
Java VM: OpenJDK 64-Bit Server VM, version: 11.0.11+9
OS: Windows 8.1, arch: amd64, version: 6.3
GFX: nVidia GTX 1050Ti Driver 471.11
SimpleFarming-2.2.0-SNAPSHOT
NicolaasJKotze added a commit to NicolaasJKotze/SimpleFarming that referenced this issue Jul 15, 2021
@NicolaasJKotze
fix(Terasology#116): Hard crash destroying Joshaberry Bush due to mis…
6efa2a2 
…sing berryseed.

Renamed the Test* string from the seed and Bush in the atlas file.
TestSeed prefab updated to use the correct berryseed.

Fixes Terasology#116
Originally, the game would hard crash when destroying a Joshaberry Bush
due to missing berryseed reference.

nothing serious

displayVersion=alpha-20
engineVersion=5.1.0-SNAPSHOT
Java: 11.0.11 in C:\Program Files\AdoptOpenJDK\jdk-11.0.11.9-hotspot
Java VM: OpenJDK 64-Bit Server VM, version: 11.0.11+9
OS: Windows 8.1, arch: amd64, version: 6.3
GFX: nVidia GTX 1050Ti Driver 471.11
SimpleFarming-2.2.0-SNAPSHOT
jdrueckert pushed a commit that referenced this issue Jul 17, 2021
@NicolaasJKotze
fix(#116): Hard crash destroying Joshaberry Bush due to missing berry…
b3c691b 
…seed. (#117)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Crash Requests, Issues and Changes targeting unexpected terminations, segfaults, etc. Category: Gameplay Content Requests, Issues and Changes targeting gameplay mechanics and content Good First Issue Good for learners that are new to Terasology Size: S Small effort likely only affecting a single area and requiring little to no research Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Bug Issues reporting and PRs fixing problems
Projects
None yet
Milestone
No milestone
2 participants
@jdrueckert @NicolaasJKotze