-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add oldwest-style buildings #89
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdrueckert
added
the
Type: Improvement
Request for or addition/enhancement of a feature
label
Aug 3, 2020
Updated issue description. |
skaldarnar
reviewed
Aug 15, 2021
Comment on lines
5
to
6
"MetalRenegades:oldwestResidentialHouse1", | ||
"MetalRenegades:oldwestResidentialHouse2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will place both buildings on top of each other, one after the other. See Terasology/DynamicCities#104 where I've added some docstrings to clarify this behavior.
skaldarnar
approved these changes
Oct 1, 2021
jdrueckert
changed the title
feat: add oldwest-style residential houses
feat: add oldwest-style buildings
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@skaldarnar and @jdrueckert just started building some old-west styled buildings for the fun of it. For now, we'll dump the structure templates in this draft PR.
As discussed on Discord, they'll eventually be ending up in themed module
OldWestCities
(naming up for discussion, this one would be in line withMedievalCities
.Depends on Terasology/DynamicCities#105
TODO: