feat: cypress/juniper and baobab trees with GrowingFlora #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naalit
added
Topic: WorldGen
skaldarnar
reviewed
Aug 14, 2021
There was a problem hiding this comment.
Additional to the comments, this also depends on what we want to do about Terasology/CoreWorlds#43
| @RegisterPlugin | ||
| public class CypressSpawn extends GrowthBasedPlantSpawnDefinition { | ||
| public CypressSpawn() { | ||
| super(PlantType.TREE, Cypress.ID, "MetalRenegades:steppe", 0.5f, 0.0007f); |
There was a problem hiding this comment.
From a bit of testing I'd increase the probability a bit here...
Suggested change
| super(PlantType.TREE, Cypress.ID, "MetalRenegades:steppe", 0.5f, 0.0007f); | |
| super(PlantType.TREE, Cypress.ID, "MetalRenegades:steppe", 0.5f, 0.0014f); |
| @@ -77,6 +77,10 @@ | |||
| "id": "Gooey", | |||
| "minVersion": "1.0.0" | |||
| }, | |||
| { | |||
| "id": "GrowingFlora", | |||
There was a problem hiding this comment.
since growing flora has a hard dependency on ClimateConditions this will automatically enable the player effects such as slow down due to heat or cold - do we want that right now in Metal Renegades?
skaldarnar
previously approved these changes
Aug 17, 2021
skaldarnar
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds juniper trees to steppes and baobabs to scrublands, using GrowingFlora and the assets from PlantPack. It depends on Terasology/GrowingFlora#38. Juniper trees are a type of cypress, so I'm using the cypress assets, and they do naturally appear in the American West; baobab trees actually live in Africa, but it's a similar environment and I think they make scrublands a lot more interesting, and baobab already exists in PlantPack unlike other tree species which would make more sense geographically.
I don't think the trees actually grow currently, although I haven't tested it extensively, and they're a lot more unpredictable than CoreWorlds' tree generation, so they sometimes end up really weird-looking. They're also cut off at chunk boundaries (Terasology/GrowingFlora#39). However, they have the potential to look nicer than CoreWorlds trees, and they're certainly a lot more varied.
A baobab
A bent juniper tree
An example of how the variation can sometimes lead to weird-looking trees