feat: implementation for economy #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skaldarnar
reviewed
Jul 26, 2021
assets/skins/DefenceDefault.skin
Outdated
| @@ -0,0 +1,29 @@ | |||
| { | |||
There was a problem hiding this comment.
this should have different name
There was a problem hiding this comment.
if we believe this is a good default for ... shop screens ... we should just add the skin to Economy.
jdrueckert
reviewed
Aug 25, 2021
module.txt
Outdated
| @@ -34,6 +34,10 @@ | |||
| "id": "Dialogs", | |||
| "minVersion": "1.0.0" | |||
| }, | |||
| { | |||
| "id": "Economy", | |||
| "minVersion": "1.1.0-SNAPSHOT" | |||
There was a problem hiding this comment.
As @skaldarnar commented in the associated GD PR: we might want to release Economy once the PR is merged and bump the version number.
| @@ -0,0 +1,219 @@ | |||
| { | |||
| "type": "ShopScreen", | |||
There was a problem hiding this comment.
I wonder if this can live in Economy as well? Or does it differ from the one we have in GD? If so, in how far?
ahv15
force-pushed
the
introduce-economy
branch
from
9953b57
to
a0f6ca9
Compare
…Shadow into introduce-economy
|
This should fix the multiplayer issues. |
jdrueckert
approved these changes
Oct 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes use of the implementation from GooeyDefence and requires Terasology/Economy#22, and needs Terasology/LightAndShadowResources#72 to test the shop screen.