fix(ecs-gestalt): Migrate Components to gestalt's Components. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skaldarnar
requested changes
Jul 12, 2021
| @Override | ||
| public void copy(KallistiComputerComponent other) { | ||
| this.on = other.on; | ||
| this.machine = other.machine; |
There was a problem hiding this comment.
I have no clue whether this is okay for Machine 🤷
There was a problem hiding this comment.
I've added a FIXME here as I don't want to look into creating a deep copy of Machine and all it's members right now ... 🙈
src/main/java/org/terasology/kcomputers/components/KallistiConnectableComponent.java
Outdated
Show resolved
Hide resolved
src/main/java/org/terasology/kcomputers/components/KallistiDisplayCandidateComponent.java
Show resolved
Hide resolved
| this.texture = other.texture; | ||
| this.pw = other.pw; | ||
| this.ph = other.ph; | ||
| this.entityManager = other.entityManager; |
There was a problem hiding this comment.
I'm not going to ask why this component holds the entity manager 🙈
src/main/java/org/terasology/kcomputers/components/KallistiDisplayComponent.java
Outdated
Show resolved
Hide resolved
src/main/java/org/terasology/kcomputers/components/KallistiInventoryWithContainerComponent.java
Outdated
Show resolved
Hide resolved
src/main/java/org/terasology/kcomputers/components/machines/KallistiTransposerComponent.java
Outdated
Show resolved
Hide resolved
Nesting components directly is an anti-pattern afaik, but since we already do it we can at least use their 'copyFrom' method to create a deep copy.
skaldarnar
approved these changes
Aug 19, 2021
jdrueckert
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: MovingBlocks/Terasology#4753