Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa: checkstyle, pmd #52

Merged
merged 2 commits into from
Nov 26, 2023
Merged

Conversation

soloturn
Copy link
Contributor

@soloturn soloturn commented Nov 17, 2023

addressed pmd and checkstyle warnings:

  • line too long
  • logger not parameterized
  • intellij warnings about formatting, e.g. @ReceiveEvent(components = {InventoryComponent.class}) replaced with @ReceiveEvent(components = InventoryComponent.class)
  • unused private field

.gitignore Outdated Show resolved Hide resolved
Comment on lines 238 to 239
BeforeItemRemovedFromInventory removeFrom = new BeforeItemRemovedFromInventory(instigator, InventoryUtils.getItemAt(from,
slotFrom), slotFrom);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider breaking lines at more readable points, e.g.

        BeforeItemRemovedFromInventory removeFrom = new BeforeItemRemovedFromInventory(instigator,
                InventoryUtils.getItemAt(from, slotFrom), slotFrom);

@jdrueckert jdrueckert changed the title qa ehckstyle, pmd qa: checkstyle, pmd Nov 17, 2023
@jdrueckert
Copy link
Member

While conventional commits are not mandatory within a PR (due to the fact that we're typically squash-merging), it does help people merging your PRs if you at least follow the convention in your PR titles

@soloturn soloturn changed the base branch from develop to chore/qaplug-findings November 19, 2023 09:08
@soloturn
Copy link
Contributor Author

While conventional commits are not mandatory within a PR (due to the fact that we're typically squash-merging), it does help people merging your PRs if you at least follow the convention in your PR titles

rebased on top of your pull request so your commits with the respective commit messages are there.

@soloturn soloturn closed this Nov 19, 2023
@soloturn soloturn reopened this Nov 19, 2023
@jdrueckert
Copy link
Member

can you please include in the PR description, which checkstyle and pmd warnings you addressed?
for one you already did it in your commit message (checkstyle, remove empty javadoc), but for the remaining changes it's unclear

quality assurance of Inventory module, mainly:
* line too long
* logger not parameterized
* intellij warnings about formatting, e.g. @ReceiveEvent(components = {InventoryComponent.class}) replaced with  @ReceiveEvent(components = InventoryComponent.class)
* unused private field
@soloturn
Copy link
Contributor Author

can you please include in the PR description, which checkstyle and pmd warnings you addressed? for one you already did it in your commit message (checkstyle, remove empty javadoc), but for the remaining changes it's unclear

updated pull request text, as well as commit message of the respective commit accordingly.

@jdrueckert jdrueckert merged commit 93b545b into Terasology:chore/qaplug-findings Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants