chore: fix import order and whitespaces #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it might well be worth doing #37 at the same time, since we have to update all the dependents either way. |
|
four other modules were similarly effected, so we'll probably want to clean them up as a batch. MovingBlocks/Terasology#4571 |
|
this can be closed @jdrueckert @keturn ? |
why? |
- files now reside in src/main/java/org/terasology/module/inventory
|
The majority of the originally intended changes was done in a similar way in #40. |
jdrueckert
changed the title
jdrueckert
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update (Nov 29, 2023):
This PR was originally intended to correct the package association of inventory classes.
The majority of these changes was done in a similar way in #40.
What's left is whitespace and import order corrections.
Original PR description:
When I went to check on this module's test failures, I discovered its packages had accidentally been moved in to the
org.terasology.enginenamespace during the migration.This PR corrects that, but I'm afraid there are probably lots of downstream modules that use InventoryComponent that will also need correcting.