-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#17): add notification on new skill learned #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all: thanks a lot for this PR, tests out like a charm ✨
Second, is there any particular reason, why you committed your logback-test.xml
? If not, please remove it from the PR.
import org.terasology.notifications.events.ShowNotificationEvent; | ||
import org.terasology.notifications.model.Notification; | ||
import org.terasology.engine.logic.players.LocalPlayer; | ||
import org.terasology.engine.logic.players.event.LocalPlayerInitializedEvent; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this unused import
import org.terasology.engine.logic.players.event.LocalPlayerInitializedEvent; |
"New Skill Acquired", | ||
"Acquired Skill " + newSkillName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can omit the repetition of "New Skill Acquired" in combination with "Acquired Skill".
How about
"New Skill Acquired", | |
"Acquired Skill " + newSkillName, | |
"Today I Learned", | |
newSkillName, |
|
This is actually my first PR so I'M kind of new to this. Will remove the XML |
💡 In that case, let's try to get a suitable version of it with the configuration we want in CI in for all omega modules @keturn |
No worries, all good, you're doing great 👍 |
added a popup notification when a new skill is acquired as per #17
Closes #17