Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#17): add notification on new skill learned #18

Merged
merged 6 commits into from
Jun 14, 2022

Conversation

MrGizmo123
Copy link
Contributor

@MrGizmo123 MrGizmo123 commented Jun 13, 2022

added a popup notification when a new skill is acquired as per #17

Closes #17

Copy link
Member

@jdrueckert jdrueckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all: thanks a lot for this PR, tests out like a charm ✨
Second, is there any particular reason, why you committed your logback-test.xml? If not, please remove it from the PR.

import org.terasology.notifications.events.ShowNotificationEvent;
import org.terasology.notifications.model.Notification;
import org.terasology.engine.logic.players.LocalPlayer;
import org.terasology.engine.logic.players.event.LocalPlayerInitializedEvent;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this unused import

Suggested change
import org.terasology.engine.logic.players.event.LocalPlayerInitializedEvent;

Comment on lines 52 to 53
"New Skill Acquired",
"Acquired Skill " + newSkillName,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can omit the repetition of "New Skill Acquired" in combination with "Acquired Skill".
How about

Suggested change
"New Skill Acquired",
"Acquired Skill " + newSkillName,
"Today I Learned",
newSkillName,

@keturn
Copy link
Contributor

keturn commented Jun 13, 2022

module get supplies logback-test.xml, and it's not git-ignored because having it in the repo lets you adjust how things show up on CI. I expect all modules will end up with one. If that sounds like a bad idea, we should talk about that (in some appropriate venue).

@MrGizmo123
Copy link
Contributor Author

This is actually my first PR so I'M kind of new to this. Will remove the XML

@jdrueckert
Copy link
Member

module get supplies logback-test.xml, and it's not git-ignored because having it in the repo lets you adjust how things show up on CI. I expect all modules will end up with one. If that sounds like a bad idea, we should talk about that (in some appropriate venue).

💡 In that case, let's try to get a suitable version of it with the configuration we want in CI in for all omega modules @keturn
With @skaldarnar's workspace tooling that should be a fairly quick change.

@jdrueckert
Copy link
Member

This is actually my first PR so I'M kind of new to this. Will remove the XML

No worries, all good, you're doing great 👍
Many first-time PRs we get don't even work or implement the desired change, but yours does that and tests out great 😃

@jdrueckert jdrueckert changed the title Added code for new skill notification feat(#17): add notification on new skill learned Jun 14, 2022
@jdrueckert jdrueckert merged commit 371bcb8 into Terasology:develop Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display Notification on Training Completion
3 participants