Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve issues with vignette #70

Merged
merged 2 commits into from
Aug 8, 2021
Merged

Conversation

pollend
Copy link
Member

@pollend pollend commented Aug 8, 2021

I moved the vignette pass into the post_frag.

@jdrueckert
Copy link
Member

Gave this a quick test in-game, but it doesn't look right.
Without vignette:
image

With vignette:
image

@jdrueckert
Copy link
Member

For reference: this is what I would expect the vignette to look like:
(note the darkened corners)
image

@skaldarnar skaldarnar added Topic: Rendering Requests, Issues and Changes related to lighting, meshes, camera, etc. Type: Bug Issues reporting and PRs fixing problems labels Aug 8, 2021
@skaldarnar
Copy link
Contributor

This might actually fix MovingBlocks/Terasology#4542 - I resized the game window a bit trying to force this issue to pop up, but could not reproduce it.

I'd go for the bold move and claim this fixed - we can always re-open the bug ticket when it occurs again.

Fixes MovingBlocks/Terasology#4542

Copy link
Contributor

@skaldarnar skaldarnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not happy to see that this removes the vignette shader and rendering node altogether and cramps it into the post processing step. I think one goal of the whole DAG thingy is to be able to implement simple effects like the vignette in any module code and just hook it up with the pipeline.

I'd highly appreciate if we'd try to get into that direction again in the future.

@skaldarnar skaldarnar changed the title bugfix: resolve issues with vignette fix: resolve issues with vignette Aug 8, 2021
@pollend
Copy link
Member Author

pollend commented Aug 8, 2021

@skaldarnar you probably don't want to do that with post processing effects. feeding the output of one shader into the next and redrawing the entire screen. umm ideally you could batch batch and combine effects together in a single shader.

@pollend pollend merged commit abc3e0c into develop Aug 8, 2021
@pollend pollend deleted the bugfix/resolve-vignette-pass branch August 8, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: Rendering Requests, Issues and Changes related to lighting, meshes, camera, etc. Type: Bug Issues reporting and PRs fixing problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants