fix: enable block tinting in LOD chunks #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keturn
reviewed
Aug 18, 2021
| * @param relZ z position of the block to get biome of, relative to the chunk view | ||
| * @return Biome of the block | ||
| */ | ||
| Optional<Biome> getBiome(ChunkView view, int relX, int relY, int relZ); |
There was a problem hiding this comment.
Should there be a set method of this form for symmetry?
There was a problem hiding this comment.
Maybe - there are already setBiome methods operating on a Chunk, though, without corresponding getBiomes.
keturn
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates for the API changes in MovingBlocks/Terasology#4847, querying biomes from the
ChunkViewused for meshing instead of theWorldProvider.