fix: enable block tinting in LOD chunks #4847
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains
Block tinting previously queried biome information from the
WorldProvider
. But LOD chunks are never added to the world, just meshed and rendered. All the necessary data is still there, so this switches to passing block tinting systems aChunkView
from which to derive necessary information, which really makes more sense anyway.How to test
With Terasology/BiomesAPI#18, try enabling LOD chunks in Core Gameplay or Metal Renegades and check that grass and leaves change color in different biomes in LOD chunks.
Here's an example, although it might be hard to see without zooming in: