Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change an array to a vector #2225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EstherWx
Copy link
Contributor

@EstherWx EstherWx commented Dec 5, 2023

Member 'IterativeParsingReaderHandler::Logs' is not initialized in the constructor and it's hard to initialize an array in the old version of Vsiual Studio. Change it to a vector and remove the need for LogCapacity and LogCount as separate members.

Move the const static variables out from the template struct 'IterativeParsingReaderHandler' to solve 'undefined reference for LOG_*' link errors.

@tencent-adm
Copy link
Member

tencent-adm commented Dec 5, 2023

CLA assistant check
All committers have signed the CLA.

@EstherWx EstherWx force-pushed the uninit-mem-var branch 3 times, most recently from b9c2ff3 to 4a95add Compare December 14, 2023 04:53
Member 'IterativeParsingReaderHandler::Logs' is not initialized in the
constructor and it's hard to initialize an array in the old version of
Vsiual Studio. Change it to a vector and remove the need for
LogCapacity and LogCount as separate members.

Move the const static variables out from the template struct
'IterativeParsingReaderHandler' to solve 'undefined reference for
LOG_*' link errors.
@EstherWx EstherWx changed the title Init the uninitialized member variable Change an array to a vector Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants