Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wifi 1335 #679

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Wifi 1335 #679

wants to merge 8 commits into from

Conversation

haricharan-candela
Copy link
Collaborator

@haricharan-candela haricharan-candela commented Jul 19, 2022 •
edited
Loading

  • Added ifconfig, ip route show and ip addr show commands output in allure reporting

ALLURE LINK

@haricharan-candela
Added ifconfig, ip route show and ip addr show command funcs in APnos…
29e4dd3 
… lib

Signed-off-by: haricharan-jaka <haricharan.jaka@candelatech.com>
@haricharan-candela
Added ifconfig, ip route show and ip addr show commands output to all…
01d6f25 
…ure before and after config apply

Signed-off-by: haricharan-jaka <haricharan.jaka@candelatech.com>
@haricharan-candela
Added ifconfig, ip route show and ip addr show commands output to all…
a056b9f 
…ure in get_ap_logs at teardown phase

Signed-off-by: haricharan-jaka <haricharan.jaka@candelatech.com>
embeddedshivam
embeddedshivam requested changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@embeddedshivam embeddedshivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haricharan-jaka Please use generic command method in panos to get the output of these commands instead of creating individiual methods

@haricharan-candela
removed ifconfig, ip route show and ip addr show command funcs in APn…
ad408fe 
…os lib

Signed-off-by: haricharan-jaka <haricharan.jaka@candelatech.com>
@haricharan-candela
Using run_generic_command for all the command output
543b30d 
Signed-off-by: haricharan-jaka <haricharan.jaka@candelatech.com>
@haricharan-candela
Using run_generic_command for all the command output in conftest also
c75d55a 
Signed-off-by: haricharan-jaka <haricharan.jaka@candelatech.com>
@haricharan-candela
changed the allure attachment names in fixtures.py file
2fd52f6 
Signed-off-by: haricharan-jaka <haricharan.jaka@candelatech.com>
@haricharan-candela
Added newline in ifconfig output
ae40710 
Signed-off-by: haricharan-jaka <haricharan.jaka@candelatech.com>
@haricharan-candela haricharan-candela self-assigned this Sep 13, 2022
@haricharan-candela haricharan-candela added the Framework Framework related label label Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embeddedshivam embeddedshivam Awaiting requested review from embeddedshivam

Requested changes must be addressed to merge this pull request.

Assignees

@haricharan-candela haricharan-candela

Labels
Framework Framework related label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haricharan-candela @embeddedshivam